Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to node 16.13.1 and remove workaround for dns lookups for domain names with underscores #3737

Closed
5 tasks done
davemcorwin opened this issue Dec 22, 2021 · 0 comments
Closed
5 tasks done

Upgrade to node 16.13.1 and remove workaround for dns lookups for domain names with underscores #3737

davemcorwin opened this issue Dec 22, 2021 · 0 comments
Assignees
@davemcorwin

Comments

@davemcorwin
Copy link
Contributor

davemcorwin commented Dec 22, 2021 •
edited

User Story

Remove workaround for bug in node when performing dns lookups for domains containing underscores.

Background (Optional)

The Cloud Foundry nodejs buildpack has been updated with node 16.13.1 which contains the fix for Node issue.

See `./api/services/Dns.js

Acceptance Criteria

The minimum node version everywhere should be 16.13.1

  • node version >=16.13.1 specified in .nvmrc
  • node version >=16.13.1 specified in package.json#engines.node
  • node version >=16.13.1 in docker files, Concourse and Circle configurations
  • Workaround removed in Dns service removed
  • Change made live via deploy Federalist app.

Level of effort - low
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davemcorwin davemcorwin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davemcorwin