Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - 2021-02-17 #3768

Merged
merged 76 commits into from Feb 17, 2022
Merged

Release - 2021-02-17 #3768

merged 76 commits into from Feb 17, 2022

Conversation

svenaas
Copy link
Contributor

@svenaas svenaas commented Feb 1, 2022

Changes proposed in this pull request:

Post deployment

  • Record these changes in the next sprint architecture review following their deployment.

security considerations

  • CodeClimate change adds more static code analysis
  • Environment creation script presents gitleaks findings but these have been manually verified and represent no real leaks. An issue has been created for preventing false positives when using environment variable.
  • Allowing Github authentication for queues UI based on membership in federalist-admins GH org, same as admin interface.

svenaas and others added 30 commits January 18, 2022 11:51
…alist-web

Parameterize app name in web interface
Correctly set site engine when adding a site
…ound

3737 upgrade node remove dns workaround
Remove nsp from CodeClimate configuration
@svenaas svenaas self-assigned this Feb 15, 2022
@svenaas svenaas changed the title Release - 2021-02-1[TBD] Release - 2021-02-16 Feb 16, 2022
@svenaas
Copy link
Contributor Author

svenaas commented Feb 16, 2022

@davemcorwin @apburnes I've believe I've pulled in security considerations from all the staging PRs which are wrapped up in this one. Can you think of anything that belongs in the post deployment section up top?

@apburnes
Copy link
Contributor

The doc hasn't been updated for this sprint yet, but we've been adding Federalist updates to the sprint architecture review so it's a good place to add the release highlights.

@svenaas
Copy link
Contributor Author

svenaas commented Feb 16, 2022

When I updated the sprint architecture review last time I directly lifted the list of changes from our latest main releases.

@svenaas
Copy link
Contributor Author

svenaas commented Feb 16, 2022

But I'll note that up top! It's a good reminder.

@svenaas
Copy link
Contributor Author

svenaas commented Feb 16, 2022

So CircleCI is timing out on federalist-queues-ui-staging and of course Concourse can't do Pages staging stuff so there are a lot of red Xes. FWIW the rest of Circle's checks are OK:

@svenaas
Copy link
Contributor Author

svenaas commented Feb 16, 2022

The CI situation makes me pretty uncomfortable but it's time for this to have other eyes on it so I'm taking it out of draft.

@svenaas svenaas marked this pull request as ready for review February 16, 2022 14:32
@svenaas svenaas requested a review from a team February 16, 2022 14:32
@svenaas svenaas changed the title Release - 2021-02-16 Release - 2021-02-17 Feb 17, 2022
@svenaas
Copy link
Contributor Author

svenaas commented Feb 17, 2022

OK, @18F/federalist-admins, CircleCI has now passed this one through build-test-deploy — thanks, I believe, to @davemcorwin's queues ui work — and we'd all benefit from your review.

Copy link
Contributor

@davemcorwin davemcorwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@svenaas svenaas merged commit 1d1f47e into main Feb 17, 2022
davemcorwin pushed a commit that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants