Add support for async_nats #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Teruel <julien.teruel@gmail.com>
JT117
force-pushed
the
feat/add_support_async_nats
branch
from
7f1c2fe
to
a765e9a
Compare
ppiotr3k
suggested changes
Sep 10, 2023
| //! Serialize [Event](https://docs.rs/cloudevents-sdk/latest/cloudevents/event/struct.Event.html) into [NatsCloudEvent] and publish to nats subject | ||
| //! ``` | ||
| //! use async_nats_lib as async_nats; | ||
| //! use cloudevents::binding::nats::NatsCloudEvent; |
There was a problem hiding this comment.
Fix needed in doc to use async bindings:
Suggested change
| //! use cloudevents::binding::nats::NatsCloudEvent; | |
| //! use cloudevents::binding::async_nats::NatsCloudEvent; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for async_nats crate, pretty much a copy/paste of the nats integration part.
The async_nats Message does not implement Clone for now hence the 'manual' clone