Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: tck tests now check that AND and OR operators are short circuit evaluated #1279

Merged
merged 3 commits into from
May 23, 2024
Merged

test: tck tests now check that AND and OR operators are short circuit evaluated #1279

merged 3 commits into from
May 23, 2024

Conversation

Cali0707
Copy link
Contributor

@Cali0707 Cali0707 commented May 8, 2024

This is a follow up on #1267 and #1270, to make sure that those changes are included in the tck tests.

Proposed Changes

  • Test that the OR operator is short circuit evaluated
  • Test that the AND operator is short circuit evaluated

@Cali0707
test: tck tests now check that AND and OR operators are short circuit…
bcc0ff4 
… evaluated

Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707
Copy link
Contributor Author

Cali0707 commented May 8, 2024

cc @pierDipi @duglin

@Cali0707
fix: test for OR short circuiting uses the OR operator
a5495cf 
Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707 Cali0707 requested a review from duglin May 16, 2024 15:58
@Cali0707
test: verify that AND and OR only short circuit when expected to
8a601e5 
Signed-off-by: Calum Murray <cmurray@redhat.com>
jskeet
jskeet approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@duglin
Copy link
Collaborator

duglin commented May 23, 2024

LGTM

@duglin
Copy link
Collaborator

duglin commented May 23, 2024

Approved on the 5/23 call

@duglin duglin merged commit e79d7b2 into cloudevents:main May 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

@duglin duglin Awaiting requested review from duglin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Cali0707 @duglin @jskeet