test: verify that invalid string literals in LIKE expression are a parse error #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rse error Signed-off-by: Calum Murray <cmurray@redhat.com>
duglin
reviewed
May 16, 2024
| @@ -116,3 +116,10 @@ tests: | |||
| - name: With type coercion from bool (4) | |||
| expression: "FALSE LIKE 'fal%'" | |||
| result: true | |||
|
|
|||
| - name: Invalid string literal in comparison causes parse error | |||
| expression: "x LIKE 123" | |||
There was a problem hiding this comment.
The doesn't say that % is required, so why is this an error?
There was a problem hiding this comment.
Because the only valid string literals in CESQL are either single quoted or double quoted. So, since 123 is not quoted it is not a string literal. See the definition for LIKE here:
string-literal ::= ( "'" ( [^'] | "\'" )* "'" ) | ( '"' ( [^"] | '\"' )* '"')
like-operator ::= "LIKE"
not-operator ::= "NOT"
like-operation ::= expression not-operator? like-operator string-literalBasically, the LIKE operator is ONLY defined where the right hand operand is a string literal, and string literals require a single or double quote
|
LGTM |
|
Approved on the 5/16 call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on discussion in sdk-go: cloudevents/sdk-go#1046 (comment)
Proposed Changes