Align to the purego build tag, removing noasm build tag
#492
+85
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2024
The `purego` build tag has been proposed[1] as the de-facto tag for
pure Go builds. This is a superset of the `noasm` tag currently used.
This patch aligns the code base to toggle to pure Go implementation
when `purego` is defined.
Verified that all assembly is excluded by doing:
find . -name '*.s' -exec sed -i -e '$athis-is-not-valid-assembly 12345' {} \;
go test --tags purego ./...
[1]: golang/go#23172
mattyclarkson
force-pushed
the
the-purest-of-pure
branch
from
6fef404 to
154f1bd
Compare
|
@armfazh would it be possible to get approval to run the CI on this PR? Thanks. |
armfazh
approved these changes
Apr 8, 2024
|
Thanks @mattyclarkson for reporting. |
|
@armfazh would it be possible to get this in a |
albertocavalcante
pushed a commit
to albertocavalcante/garf
that referenced
this pull request
Mar 21, 2025
albertocavalcante
added a commit
to albertocavalcante/garf
that referenced
this pull request
Mar 25, 2025
…x `circl` issue (#39) * set bazel.queriesShareServer to false * enable all starpls experimental features * manage tools dependencies for nogo separately * bump go_sdk toolchain to 1.23.7 * buildifier: remove natic-cc and native-java warnings to make it happy * jfrogclient: add required 'UploadServiceOptions' arg * upgrade jfrog-client-go to v1.51.1 * update go sum * nogo: move it to behind a macro * disable nogo for now * upate nogo_tools mod and sum * update nogo use_repos * remove circl bcr patches bazel-contrib/rules_go#3901 cloudflare/circl#492 * update use_repo for zig toolchans * remove hermetic_cc_toolchain * add flag to avoid using local cc toolchain * Revert "remove circl bcr patches" This reverts commit f10a072. * add bazel-lib * circl workaround: use define flag to set gotags * set pure=on for go_binary targets * remove circl bcr patches * make pkg a target * add target to create aspect bazel-lib correctness rc * remove hermetic cc toolchain again * add and import correctness rc flags * add tasks.json * add devcontainer * updte devcontainer * add README to rc presets * update lockfile * add cursor rules * move bazel settings ot the top * fix analyzers type hints * nogo: run Vet only, make it work wrh downgraded version * add rule for go/golang/go sdk * update go sdk back to 1.23.7 * add rule for bazel * nogo analyzers: add exhaustive label * add missing BUILD export_files to tools/nogo * use the latest glang.org/x/tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
puregobuild tag has been proposed1 as the de-facto tag for pure Go builds. This is a superset of thenoasmtag currently used.This patch aligns the code base to toggle to pure Go implementation when
puregois defined.Verified that all assembly is excluded by doing:
Closes #491