Merge pull request #1275 from jacobbednarz/allow-preserve-query-strin…

…g-to-be-nullable rulesets: allow `PreserveQueryString` to be nullable
cloudflare · May 4, 2023 · 1a227fd · 1a227fd
2 parents 288fd1b + 81239df
commit 1a227fd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/.changelog/1275.txt b/.changelog/1275.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+rulesets: allow `PreserveQueryString` to be nullable
+```
diff --git a/rulesets.go b/rulesets.go
@@ -275,7 +275,7 @@ type RulesetRuleActionParametersAutoMinify struct {
 type RulesetRuleActionParametersFromValue struct {
 	StatusCode          uint16                               `json:"status_code,omitempty"`
 	TargetURL           RulesetRuleActionParametersTargetURL `json:"target_url"`
-	PreserveQueryString bool                                 `json:"preserve_query_string,omitempty"`
+	PreserveQueryString *bool                                `json:"preserve_query_string,omitempty"`
 }
 
 type RulesetRuleActionParametersTargetURL struct {

diff --git a/rulesets_test.go b/rulesets_test.go
@@ -523,7 +523,7 @@ func TestGetRuleset_RedirectFromValue(t *testing.T) {
 				TargetURL: RulesetRuleActionParametersTargetURL{
 					Value: "some_host.com",
 				},
-				PreserveQueryString: true,
+				PreserveQueryString: BoolPtr(true),
 			},
 		},
 		Description: "Set dynamic redirect from value",