Skip to content

Commit

Permalink
Merge pull request #1424 from pierreca/biso/add-non-identity-bool
Browse files Browse the repository at this point in the history
Add Browser Isolation Non-identity onramp support
  • Loading branch information
jacobbednarz committed Oct 23, 2023
2 parents 3010fdd + f9d27f3 commit a9c1887
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 1 deletion.
7 changes: 7 additions & 0 deletions .changelog/1424.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
```release-note:enhancement
teams: Add `non_identity_enabled` boolean in browser isolation settings
```

```release-note:breaking-change
teams: `BrowserIsolation.UrlBrowserIsolationEnabled` has changed from `bool` to `*bool` to meet the library conventions
```
3 changes: 2 additions & 1 deletion teams_accounts.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ type TeamsAccountSettings struct {
}

type BrowserIsolation struct {
UrlBrowserIsolationEnabled bool `json:"url_browser_isolation_enabled"`
UrlBrowserIsolationEnabled *bool `json:"url_browser_isolation_enabled,omitempty"`
NonIdentityEnabled *bool `json:"non_identity_enabled,omitempty"`
}

type TeamsAntivirus struct {
Expand Down
8 changes: 8 additions & 0 deletions teams_accounts_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ func TestTeamsAccountConfiguration(t *testing.T) {
"background_color": "#ff0000",
"suppress_footer": true
},
"browser_isolation": {
"url_browser_isolation_enabled": true,
"non_identity_enabled": true
},
"body_scanning": {
"inspection_mode": "deep"
}
Expand Down Expand Up @@ -112,6 +116,10 @@ func TestTeamsAccountConfiguration(t *testing.T) {
MailtoSubject: "Blocked User Inquiry",
SuppressFooter: BoolPtr(true),
},
BrowserIsolation: &BrowserIsolation{
UrlBrowserIsolationEnabled: BoolPtr(true),
NonIdentityEnabled: BoolPtr(true),
},
})
}
}
Expand Down

0 comments on commit a9c1887

Please sign in to comment.