Merge pull request #1242 from rexscaria/rex/teams-changes

feat: updated gateway teams rule settings
cloudflare · Mar 23, 2023 · a9f0947 · a9f0947
2 parents 0a69e78 + 7cac7f3
commit a9f0947
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/.changelog/1242.txt b/.changelog/1242.txt
@@ -0,0 +1,7 @@
+```release-note:bug
+teams_rules: `AllowChildBypass` changes from a `bool` to `*bool`
+```
+
+```release-note:bug
+teams_rules: `BypassParentRule` changes from a `bool` to `*bool`
+```
diff --git a/teams_rules.go b/teams_rules.go
@@ -48,11 +48,11 @@ type TeamsRuleSettings struct {
 	// Turns on ip category based filter on dns if the rule contains dns category checks
 	IPCategories bool `json:"ip_categories"`
 
-	// Allow parent MSP accounts to enable bypass their children's rules.
-	AllowChildBypass bool `json:"allow_child_bypass"`
+	// Allow parent MSP accounts to enable bypass their children's rules. Do not set them for non MSP accounts.
+	AllowChildBypass *bool `json:"allow_child_bypass,omitempty"`
 
-	// Allow child MSP accounts to bypass their parent's rules
-	BypassParentRule bool `json:"bypass_parent_rule"`
+	// Allow child MSP accounts to bypass their parent's rules. Do not set them for non MSP accounts.
+	BypassParentRule *bool `json:"bypass_parent_rule,omitempty"`
 
 	// Action taken when an untrusted origin certificate error occurs in a http allow rule
 	UntrustedCertSettings *UntrustedCertSettings `json:"untrusted_cert"`