feat: adds OriginRequest field to UnvalidatedIngressRule struct. #1138
Conversation
Signed-off-by: keita <keitap@gmail.com>
Signed-off-by: keita <keitap@gmail.com>
|
changelog detected ✅ |
| Hostname string `json:"hostname,omitempty"` | ||
| Path string `json:"path,omitempty"` | ||
| Service string `json:"service,omitempty"` | ||
| OriginRequest *OriginRequestConfig `json:"originRequest,omitempty"` |
There was a problem hiding this comment.
@jacobbednarz Should I make a new struct like IngressOriginRequestConfig since I believe ingress.originRequest is not identical to top-level originRequest?
|
@jacobbednarz If not satisfied any requirements, let me know. |
|
@jacobbednarz any chances to get this one rolling? i think a lot of people were waiting for this issue cloudflare/terraform-provider-cloudflare#1756 to be resolved, but apparently, the solution to this feature in Terraform provider is still not usable because of the inability to configure the origin requests for ingress rules... |
|
@jacobbednarz I thought it is publicly documented here. Is it not sufficient or beta feature? It would be helpful if you could tell me what exactly is needed so that next time I don't send a pull request that doesn't meet your requirements :) |
The example is not public documentation that implies a stable API contract. The attributes, their types and what their description are missing.
This is the same issue that has was mentioned in #1099 and why it hasn't been merged or picked up again. We don't yet have public documentation so it won't land in our SDKs that rely on a stable interface. |
|
@jacobbednarz Do you know when it will be stable, by the way? |
|
@jacobbednarz sorry, but who is responsible for the documentation and how to push them while being an enterprise CF customer? the amount of bureaucracy is just ridiculous, the feature is there, it's blocking other long awaited tunnel config feature in Terraform provider, but since for some reason some other party who is not even here and not in context can't update the docs for X months, we can't get it implemented to finally be able to properly/fully cover CF ZT tunnels with IaC |
|
@hatemosphere you can speak with your account team who can track the priority of the documentation changes against the teams' backlog. |
|
This is really important, how we can move this forward? |
|
@jacobbednarz I'm also an enterprise customer, and this is also blocking us. Do you have any news on when this can be merged and used? |
Codecov Report
@@ Coverage Diff @@
## master #1138 +/- ##
=======================================
Coverage 49.07% 49.07%
=======================================
Files 134 134
Lines 13091 13091
=======================================
Hits 6425 6425
Misses 5162 5162
Partials 1504 1504
|
|
This functionality has been released in v0.68.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Add OriginRequest field to UnvalidatedIngressRule struct documented here.
Fixes: #1098
I'm aware #1099 but it seems like not active so I created this.
Has your change been tested?
Yes
Types of changes
What sort of change does your code introduce/modify?
Checklist: