Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tunnel API Structs #1099

Closed
wants to merge 3 commits into from

Conversation

TroyKomodo
Copy link

@TroyKomodo TroyKomodo commented Oct 3, 2022

Update the Tunnel (cloudflared) API structs so that they reflect the current API/Cloudflared configs.

Description

Copied changes from cloudflared into this repo.

Currently aswell not sure where to report but the docs (https://api.cloudflare.com/#cloudflare-tunnel-configuration-properties) State that the API returns a JSON string, however this is not the case.

Has your change been tested?

No.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

fixes #1098

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/cloudflare-go/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

@jacobbednarz
Copy link
Member

as this field isn't publicly documented, we can't yet accept the PR. before we add fields, they need to be documented to ensure they are intended for public consumption and considered stable.

feel free to raise a Cloudflare support ticket with the details of what is missing and once that is addressed by the service team, we can land this one.

@asychev
Copy link

asychev commented Feb 20, 2023

Any updates on ETA?

@TroyKomodo
Copy link
Author

I am not sure, I haven't been told anything about the state of this PR

@jacobbednarz
Copy link
Member

superseded by #1138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update TunnelConfig Responses in documentation as well as in SDK
3 participants