Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetR2Bucket #1265

Merged
merged 9 commits into from May 23, 2023
Merged

Add GetR2Bucket #1265

merged 9 commits into from May 23, 2023

Conversation

Cyb3r-Jak3
Copy link
Contributor

@Cyb3r-Jak3 Cyb3r-Jak3 commented Apr 13, 2023

Description

  • Adds GetR2Bucket for getting info for individual buckets
  • Changes CreationTime to *time.Time

Has your change been tested?

All tests pass

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs. (soon™️)

@github-actions
Copy link
Contributor

changelog detected ✅

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Merging #1265 (305ee56) into master (62eaa9a) will increase coverage by 0.00%.
The diff coverage is 61.29%.

@@           Coverage Diff           @@
##           master    #1265   +/-   ##
=======================================
  Coverage   49.06%   49.07%           
=======================================
  Files         134      134           
  Lines       13066    13091   +25     
=======================================
+ Hits         6411     6424   +13     
- Misses       5155     5163    +8     
- Partials     1500     1504    +4     
Impacted Files Coverage Δ
r2_bucket.go 66.12% <61.29%> (-9.55%) ⬇️

r2_bucket.go Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz mentioned this pull request May 10, 2023
9 tasks
@Cyb3r-Jak3
Copy link
Contributor Author

@jacobbednarz The docs are now live for this

@jacobbednarz jacobbednarz merged commit c6fcae3 into cloudflare:master May 23, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.68.0 milestone May 23, 2023
github-actions bot pushed a commit that referenced this pull request May 23, 2023
@jacobbednarz
Copy link
Member

thanks! i'll work with sid to get the docs corrected here as the structure is a little out but i see the intent.

@github-actions
Copy link
Contributor

This functionality has been released in v0.68.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@Cyb3r-Jak3 Cyb3r-Jak3 deleted the get-r2-bucket branch May 24, 2023 00:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants