Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R2 bucket #2378

Merged
merged 15 commits into from
May 24, 2023
Merged

R2 bucket #2378

merged 15 commits into from
May 24, 2023

Conversation

Cyb3r-Jak3
Copy link
Contributor

@Cyb3r-Jak3 Cyb3r-Jak3 commented Apr 15, 2023

Adds basic management for R2 buckets.

Closes #1664.

@github-actions
Copy link
Contributor

changelog detected ✅

@Cyb3r-Jak3
Copy link
Contributor Author

Needs cloudflare/cloudflare-go#1265

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@github-actions
Copy link
Contributor

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@jacobbednarz jacobbednarz added workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. and removed lifecycle/stale labels May 23, 2023
@Cyb3r-Jak3
Copy link
Contributor Author

Should be good once #2466 is merged.

@jacobbednarz jacobbednarz removed the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label May 24, 2023
@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/framework/service/r2_bucket -v -count 1 -run ^TestAccCloudflareR2Bucket_ -timeout 120m -parallel 1
=== RUN   TestAccCloudflareR2Bucket_Basic
=== PAUSE TestAccCloudflareR2Bucket_Basic
=== RUN   TestAccCloudflareR2Bucket_Minimum
=== PAUSE TestAccCloudflareR2Bucket_Minimum
=== CONT  TestAccCloudflareR2Bucket_Basic
--- PASS: TestAccCloudflareR2Bucket_Basic (20.84s)
=== CONT  TestAccCloudflareR2Bucket_Minimum
--- PASS: TestAccCloudflareR2Bucket_Minimum (16.78s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/r2_bucket	38.431s

@jacobbednarz
Copy link
Member

i've also updated this PR to close #1664 as we don't want laundry list support issues. instead, we want specific issues that cover each part that can be tackled separately. the OP in the attached issue was after bucket support which we are adding here.

@jacobbednarz jacobbednarz merged commit 8bc7f01 into cloudflare:master May 24, 2023
8 checks passed
@github-actions github-actions bot added this to the v4.7.0 milestone May 24, 2023
github-actions bot pushed a commit that referenced this pull request May 24, 2023
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the r2-bucket branch May 25, 2023 21:52
@github-actions
Copy link
Contributor

This functionality has been released in v4.7.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resources for managing R2
2 participants