Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rulesets: allow PreserveQueryString to be nullable #1275

Conversation

jacobbednarz
Copy link
Member

Updates the PreserveQueryString field to be a boolean pointer to be nullable.

@jacobbednarz jacobbednarz force-pushed the allow-preserve-query-string-to-be-nullable branch from ae7cb54 to 62b01a5 Compare May 4, 2023 06:07
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

changelog detected ✅

@jacobbednarz jacobbednarz force-pushed the allow-preserve-query-string-to-be-nullable branch from 62b01a5 to 81239df Compare May 4, 2023 21:53
@jacobbednarz jacobbednarz merged commit 1a227fd into cloudflare:master May 4, 2023
11 checks passed
@jacobbednarz jacobbednarz deleted the allow-preserve-query-string-to-be-nullable branch May 4, 2023 21:56
@github-actions github-actions bot added this to the v0.67.0 milestone May 4, 2023
github-actions bot pushed a commit that referenced this pull request May 4, 2023
jacobbednarz added a commit to cloudflare/terraform-provider-cloudflare that referenced this pull request May 8, 2023
… be nullable

Updates the `FromValue.PreserveQueryString` handling in the request + state
handler to use the changes from cloudflare/cloudflare-go#1275 and allows
conditional handling of null in resources.

Closes #2408
jacobbednarz added a commit to cloudflare/terraform-provider-cloudflare that referenced this pull request May 8, 2023
… be nullable

Updates the `FromValue.PreserveQueryString` handling in the request + state
handler to use the changes from cloudflare/cloudflare-go#1275 and allows
conditional handling of null in resources.

Closes #2408
@github-actions
Copy link
Contributor

This functionality has been released in v0.67.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant