Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix priority not being set when updating MX records #1290

Merged
merged 3 commits into from May 23, 2023
Merged

Fix priority not being set when updating MX records #1290

merged 3 commits into from May 23, 2023

Conversation

hmoffatt
Copy link
Contributor

Description

Since #1170 , it is not possible to update the priority of an MX record. The priority is not sent in the PATCH update request. Also discussed in #1282 .

Has your change been tested?

I've tested this manually with flarectl.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2023

changelog detected ✅

dns.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #1290 (f0f5570) into master (a5dc232) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1290   +/-   ##
=======================================
  Coverage   49.07%   49.07%           
=======================================
  Files         134      134           
  Lines       13091    13091           
=======================================
  Hits         6425     6425           
  Misses       5162     5162           
  Partials     1504     1504           
Impacted Files Coverage Δ
dns.go 45.05% <ø> (ø)

@jacobbednarz jacobbednarz merged commit 11f4d14 into cloudflare:master May 23, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.68.0 milestone May 23, 2023
github-actions bot pushed a commit that referenced this pull request May 23, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.68.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@hmoffatt hmoffatt deleted the fix-update-mx-priority branch May 24, 2023 00:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants