Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix priority not being set when updating MX records #1290

Merged
merged 3 commits into from
May 23, 2023
Merged

Fix priority not being set when updating MX records #1290

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a97f7d7
Fix priority not being set when updating MX records
hmoffatt May 23, 2023
77433eb
Add changelog entry for #1290
hmoffatt May 23, 2023
f0f5570
fix struct tag enclosure quotes
jacobbednarz May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/1290.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
dns: fix MX record priority not set by UpdateDNSRecord
```
2 changes: 1 addition & 1 deletion dns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
Content string `json:"content,omitempty"`
Data interface{} `json:"data,omitempty"` // data for: SRV, LOC
ID string `json:"-"`
Priority *uint16 `json:"-"` // internal use only
Priority *uint16 `json:"priority,omitempty`

Check failure on line 77 in dns.go

View workflow job for this annotation

GitHub Actions / test (1.18) 

struct field tag `json:"priority,omitempty` not compatible with reflect.StructTag.Get: bad syntax for struct tag value

Check failure on line 77 in dns.go

View workflow job for this annotation

GitHub Actions / lint 

structtag: struct field tag `json:"priority,omitempty` not compatible with reflect.StructTag.Get: bad syntax for struct tag value (govet)
jacobbednarz marked this conversation as resolved.
Show resolved Hide resolved
TTL int `json:"ttl,omitempty"`
Proxied *bool `json:"proxied,omitempty"`
Comment string `json:"comment"`
Expand Down