Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queueing_status_code to Waiting Room object #1357

Merged

Conversation

emmanuelclflores
Copy link

Description

Waiting Room has a new configuration field queueing_status_code that determines what HTTP status code is returned to a user while in the queue.

See the API docs for more information.

Has your change been tested?

Yes, relevant unit tests have been updated to handle the addition of this field. Additionally, changes were ran against the pre-existing test suite to verify that no regressions were introduced.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

changelog detected ✅

@emmanuelclflores emmanuelclflores changed the title Add queueing status code to waiting room Add queueing_status_code to Waiting Room object Aug 5, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1357 (958bd23) into master (b9ac804) will increase coverage by 0.16%.
Report is 102 commits behind head on master.
The diff coverage is 58.26%.

@@            Coverage Diff             @@
##           master    #1357      +/-   ##
==========================================
+ Coverage   48.33%   48.50%   +0.16%     
==========================================
  Files         133      135       +2     
  Lines       13023    13202     +179     
==========================================
+ Hits         6295     6403     +108     
- Misses       5201     5247      +46     
- Partials     1527     1552      +25     
Files Changed Coverage Δ
access_application.go 72.72% <ø> (ø)
access_organization.go 53.84% <ø> (ø)
device_posture_rule.go 61.80% <ø> (ø)
load_balancing.go 59.40% <ø> (ø)
teams_accounts.go 53.84% <ø> (ø)
waiting_room.go 45.72% <ø> (ø)
regional_tiered_cache.go 43.75% <43.75%> (ø)
logpush.go 51.81% <46.15%> (-0.30%) ⬇️
images.go 44.70% <47.82%> (-0.12%) ⬇️
access_custom_page.go 48.27% <48.27%> (ø)
... and 7 more

@jacobbednarz jacobbednarz merged commit b634d4b into cloudflare:master Aug 7, 2023
10 checks passed
@jacobbednarz
Copy link
Member

thank you @emmanuelclflores 🥇

@github-actions
Copy link
Contributor

This functionality has been released in v0.75.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants