Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_waiting_room: Add queueing_status_code to the Waiting Room resource #2666

Merged

Conversation

emmanuelclflores
Copy link

@emmanuelclflores emmanuelclflores commented Aug 7, 2023

Waiting Room has a new configuration field queueing_status_code that determines what HTTP status code is returned to a user while in the queue. Adds support for queueing_status_code to the Waiting Room resource.

Depends on cloudflare/cloudflare-go#1357

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

changelog detected ✅

@jacobbednarz jacobbednarz added the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Aug 8, 2023
@jacobbednarz jacobbednarz removed the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Aug 15, 2023
@jacobbednarz
Copy link
Member

acceptance tests all looking good

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareWaitingRoom_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareWaitingRoom_Create
=== PAUSE TestAccCloudflareWaitingRoom_Create
=== CONT  TestAccCloudflareWaitingRoom_Create
--- PASS: TestAccCloudflareWaitingRoom_Create (15.38s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	15.845s

@jacobbednarz jacobbednarz merged commit 3d9d666 into cloudflare:master Aug 15, 2023
9 checks passed
@github-actions github-actions bot added this to the v4.13.0 milestone Aug 15, 2023
github-actions bot pushed a commit that referenced this pull request Aug 15, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v4.13.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants