Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Bot Management #1363

Merged

Conversation

cwlowder
Copy link

@cwlowder cwlowder commented Aug 7, 2023

Description

This change updates the SDK to properly support updating and retrieving the bot management configuration for a zone.

Closes #467

Has your change been tested?

Yes, I have included unit tests in this PR. I have also manually tested the changes to verify that my changes work as expected.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation. (done)[https://developers.cloudflare.com/api/operations/bot-management-for-a-zone-get-config]
  • I have updated the documentation accordingly. (done)[https://developers.cloudflare.com/api/operations/bot-management-for-a-zone-get-config]
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

changelog detected ✅

@cwlowder cwlowder force-pushed the cwlowder/add-bot-management-support branch from d354623 to c6c1b4f Compare August 7, 2023 21:29
@codecov-commenter
Copy link

Codecov Report

Merging #1363 (a66aab4) into master (b9ac804) will increase coverage by 0.17%.
Report is 115 commits behind head on master.
The diff coverage is 57.80%.

@@            Coverage Diff             @@
##           master    #1363      +/-   ##
==========================================
+ Coverage   48.33%   48.50%   +0.17%     
==========================================
  Files         133      136       +3     
  Lines       13023    13239     +216     
==========================================
+ Hits         6295     6422     +127     
- Misses       5201     5261      +60     
- Partials     1527     1556      +29     
Files Changed Coverage Δ
access_application.go 72.72% <ø> (ø)
access_audit_log.go 79.31% <ø> (ø)
access_bookmark.go 72.44% <ø> (ø)
access_ca_certificate.go 68.00% <ø> (ø)
access_group.go 70.00% <ø> (ø)
access_identity_provider.go 66.32% <ø> (ø)
access_keys.go 71.42% <ø> (ø)
access_mutual_tls_certificates.go 68.86% <ø> (ø)
access_organization.go 53.84% <ø> (ø)
access_service_tokens.go 51.85% <ø> (ø)
... and 118 more

@jacobbednarz jacobbednarz merged commit 9dabf11 into cloudflare:master Aug 8, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.75.0 milestone Aug 8, 2023
github-actions bot pushed a commit that referenced this pull request Aug 8, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.75.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Cloudflare Bot Management
3 participants