resource/cloudflare_bot_managment: add Bot Management resource

[cwlowder]

Cloudflare-Go has been updated to include bot_management, we should update terraform to also include this change.

Depends on cloudflare/cloudflare-go#1363

Closes #693

[github-actions]

This project handles dependency version bumps (including upstream changes from cloudflare-go) independently of the standard PR process using automation. This allows the dependency upgrades to land without causing merge conflicts in multiple branches and handled in a consistent way. The exception to this is security related dependency upgrades but they should be co-ordinated with the maintainer team privately.

Please remove the changes to the go.mod or go.sum files from this PR in order to proceed with review and merging.

[github-actions]

changelog detected ✅

[cwlowder]

Cloudflare-go was updated, decided to do some more testing. Had to update the PR, but I keep getting this error when I run terraform apply in my test setup locally:

cloudflare_bot_management.bm_bots_config: Creating...
╷
│ Error: Provider produced inconsistent result after apply
│ 
│ When applying changes to cloudflare_bot_management.bm_bots_config, provider "provider[\"registry.terraform.io/cloudflare/cloudflare\"]" produced an
│ unexpected new value: Root resource was present, but now absent.
│ 
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.

@jacobbednarz thoughts?

[jacobbednarz]

@cwlowder that looks like it removed the resource due to it missing from the provider. i just bumped the Go library here so you should be able to re-run these tests now and have them work. otherwise, i can take a look shortly.

[jacobbednarz]

ah, i can see a couple of issues here:

• your test cases are referencing cloudflare_api_shield
• you're missing a d.SetId call which is used as a lookup anchor (tfproviderlint is also complaining about this) and why the test cannot find the resource despite it actually being created.

i'll push up a couple of commits addressing this and you can take a look if you'd like :)

[jacobbednarz]

@cwlowder i went ahead and pushed up those fixes. would you mind eyeballing the unentitled test case as i think i know what you were trying to achieve there but do want to be sure before we merge it that was the intention.

acceptance tests are passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareBotManagement_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareBotManagement_SBFM
--- PASS: TestAccCloudflareBotManagement_SBFM (19.36s)
=== RUN   TestAccCloudflareBotManagement_Unentitled
--- PASS: TestAccCloudflareBotManagement_Unentitled (7.19s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	27.512s

[cwlowder]

My intention is that some zones, like a free zone, will not be able to turn on SBFM or disable auto updating of the ml model. When you attempt to do so, the API will return an error. I want to test that behavior.

[jacobbednarz]

perfect. that is the behaviour I accounted for here so I think we're good to merge.

thanks!

[github-actions]

This functionality has been released in v4.13.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!