Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Get/Update API Shield Operation Schema Validation settings #1422

Merged
merged 1 commit into from Oct 22, 2023

Conversation

djhworld
Copy link
Contributor

@djhworld djhworld commented Oct 13, 2023

Adds support for the following endpoints

Description

Has your change been tested?

  • Unit tests
  • Local testing

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

changelog detected ✅

@djhworld djhworld marked this pull request as ready for review October 16, 2023 16:48
@djhworld djhworld changed the title APISHI-2373 Add support for Get/Update API Shield Operation Schema Validation settings Add support for Get/Update API Shield Operation Schema Validation settings Oct 16, 2023
// UpdateAPIShieldOperationSchemaValidationSettings updates operation level schema validation settings
//
// API documentation: https://developers.cloudflare.com/api/operations/api-shield-schema-validation-update-operation-level-settings
func (api *API) UpdateAPIShieldOperationSchemaValidationSettings(ctx context.Context, rc *ResourceContainer, params UpdateAPIShieldOperationSchemaValidationSettingsParams) (*APIShieldOperationSchemaValidationSettings, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to my comment in #1418 (comment), do we need both of these update methods? or could we use the one that accepts multiple updates for both?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, have updated to remove the single one in favour of the multiple one (and renamed it to just be UpdateAPIShieldOperationSchemaValidationSettings)

…lidation Settings

Adds support for the following endpoints

- Retrieve operation level schema validation settings
- Update multiple operation level schema validation settings
@jacobbednarz jacobbednarz merged commit 8e3cfea into cloudflare:master Oct 22, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.80.0 milestone Oct 22, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.80.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants