Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_api_shield_operation_schema_validation_settings #2852

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

djhworld
Copy link
Contributor

Adds new resource resource/cloudflare_api_shield_operation_schema_validation_settings

Cloudflare-Go has been updated to include support for operation-level schema validation settings in API Shield Schema Validation 2.0

This PR updates the terraform provider to support managing these settings in API Shield

Depends on cloudflare/cloudflare-go#1422

@github-actions
Copy link
Contributor

changelog detected ✅

@djhworld djhworld force-pushed the APISHI-2374 branch 3 times, most recently from 9b6380b to b17c46e Compare October 16, 2023 16:06
@jacobbednarz
Copy link
Member

the cloudflare-go library has been bumped so if you rebase from master, this should now be in a better spot.

@djhworld djhworld force-pushed the APISHI-2374 branch 5 times, most recently from 24005da to 4991550 Compare October 26, 2023 14:41
@djhworld djhworld marked this pull request as ready for review October 26, 2023 14:48
@djhworld
Copy link
Contributor Author

the cloudflare-go library has been bumped so if you rebase from master, this should now be in a better spot.

@jacobbednarz thanks - Have rebased + updated this PR and #2841 and builds pass now.

@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareAPIShieldOperationSchemaValidationSettings_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareAPIShieldOperationSchemaValidationSettings_Create
--- PASS: TestAccCloudflareAPIShieldOperationSchemaValidationSettings_Create (28.99s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	30.333s

@jacobbednarz jacobbednarz merged commit f987100 into cloudflare:master Oct 30, 2023
9 checks passed
@github-actions github-actions bot added this to the v4.18.0 milestone Oct 30, 2023
github-actions bot pushed a commit that referenced this pull request Oct 30, 2023
Copy link
Contributor

This functionality has been released in v4.18.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants