Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Opt-In Split Tunnel Overlapping IPs #1454

Merged
merged 1 commit into from Dec 5, 2023

Conversation

da-cf
Copy link
Contributor

@da-cf da-cf commented Dec 1, 2023

Description

Add two new fields to the device settings policy. This is to add API support for the Opt-In Split Tunnel Overlapping IPs feature:

  1. lan_allow_minutes (uint) used to set the amount of time a user can access a LAN subnet.
  2. lan_allow_subnet_size (uint) the allowed subnet size for the lan

Has your change been tested?

Added to existing device settings policy tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

github-actions bot commented Dec 1, 2023

changelog detected ✅

devices_policy.go Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit fcd3dc6 into cloudflare:master Dec 5, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.83.0 milestone Dec 5, 2023
github-actions bot pushed a commit that referenced this pull request Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

This functionality has been released in v0.83.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants