Add support for Opt-In Split Tunnel Overlapping IPs

[da-cf]

Add two new fields to the device settings policy. This is to add API support for the Opt-In Split Tunnel Overlapping IPs feature:

lan_allow_minutes (uint) used to set the amount of time a user can access a LAN subnet.
lan_allow_subnet_size (uint) the allowed subnet size for the lan

Depends on cloudflare-go PR #1454.

[github-actions]

changelog detected ✅

[github-actions]

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

[da-cf]

Work has been de-prioritized, but will be picked back up within the coming weeks.

[github-actions]

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

[jacobbednarz]

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareDeviceSettingsPolicy_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareDeviceSettingsPolicy_Create
--- PASS: TestAccCloudflareDeviceSettingsPolicy_Create (19.78s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	20.841s

@da-cf looking at your schema, i see some slightly confusing behaviour. lan_allow_minutes is optional however, we are always sending it which will result in "0". is this intentional? i don't think so but wanted to confirm. lan_allow_subnet_size has a default of "24" so we'll always send that too. is that your intention? we probably want to update these test cases to explicitly cover both of these cases as previously, it just wasn't being defined and had a bit of copy pasta from other tests.

[da-cf]

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareDeviceSettingsPolicy_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareDeviceSettingsPolicy_Create
--- PASS: TestAccCloudflareDeviceSettingsPolicy_Create (19.78s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	20.841s

@da-cf looking at your schema, i see some slightly confusing behaviour. lan_allow_minutes is optional however, we are always sending it which will result in "0". is this intentional? i don't think so but wanted to confirm. lan_allow_subnet_size has a default of "24" so we'll always send that too. is that your intention? we probably want to update these test cases to explicitly cover both of these cases as previously, it just wasn't being defined and had a bit of copy pasta from other tests.

Thanks for catching this. This completely slipped my mind.

Both fields are optional, and should not be returned at all in a JSON response if they are nil. The subnet size also should not have a default value. I've updated the PR to reflect this.

[jacobbednarz]

looks like we've got some differences in the resource refresh

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareDeviceSettingsPolicy_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareDeviceSettingsPolicy_Create
    resource_cloudflare_device_settings_policy_test.go:31: Step 2/4 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # cloudflare_device_settings_policy.krhnceymym will be updated in-place
          ~ resource "cloudflare_device_settings_policy" "krhnceymym" {
              ~ default               = false -> true
                id                    = "f037e56e89293a057740de681ac9abbe/aa252f0d-aa52-4829-92f0-f135e77bd398"
              - match                 = "identity.email == \"foo@example.com\"" -> null
                name                  = "krhnceymym"
              - precedence            = 10 -> null
                # (16 unchanged attributes hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccCloudflareDeviceSettingsPolicy_Create (14.42s)
FAIL
FAIL	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	14.829s
FAIL
make: *** [testacc] Error 1

[github-actions]

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

[da-cf]

Finishing up fixing the tests today. Will add a comment here when I'm ready to merge :)

[github-actions]

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

[github-actions]

This PR was closed because it has been stalled for 7 days with no activity.