Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logpush: modernise methods #1326

Merged
merged 2 commits into from
Jul 5, 2023
Merged

logpush: modernise methods #1326

merged 2 commits into from
Jul 5, 2023

Commits on Jul 5, 2023

  1. logpush: modernise methods 

    Updates the logpush methods to:

- Use the newer client method signatures - Remove the duplicate internal methods
for account/zone level methods in favour of using `*ResourceContainer` - Stop
using `AccessIdentifiers`

This introduces a bit more duplication in the `Create`/`Update` methods however
it does allow us to handle creation and updates separately explicitly instead
of bunching all the logic into a single method with conditionals.
    @jacobbednarz
    jacobbednarz committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    978579f View commit details
    Browse the repository at this point in the history

  2. access_policy: update more references and method signatures

    @jacobbednarz
    jacobbednarz committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    0a58e18 View commit details
    Browse the repository at this point in the history