Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace encoding/json with github.com/goccy/go-json #1360

Merged
merged 3 commits into from
Aug 7, 2023
Merged

replace encoding/json with github.com/goccy/go-json #1360

merged 3 commits into from
Aug 7, 2023

Commits on Aug 7, 2023

  1. replace encoding/json with github.com/goccy/go-json 

    The stdlib has some, ermm, quirks with how certain methods handle strings
without a way to customise that behaviour. This bites us in cases where our API
payloads (represented as bytes) *shouldn't* be escaping HTML entities however
they end up escaped and won't match our internal representation of them.

Instead of doing hacky work arounds, I've just swapped out `encoding/json` with
`github.com/goccy/go-json` which mentions it is a drop in replacement but, it
includes a way to customise certain behaviours as needed.
    @jacobbednarz
    jacobbednarz committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    7e066fe View commit details
    Browse the repository at this point in the history

  2. cache_purge: don't escape HTML entities in URLs 

    Ensures the exact cache key will match that which we have stored.

Closes #1350
    @jacobbednarz
    jacobbednarz committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    bf2c717 View commit details
    Browse the repository at this point in the history

  3. tools: add goimports to local toolkit

    @jacobbednarz
    jacobbednarz committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    c4897fb View commit details
    Browse the repository at this point in the history