Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display all listening addresses #332

Merged
merged 1 commit into from Aug 12, 2022
Merged

Conversation

Skye-31
Copy link
Contributor

@Skye-31 Skye-31 commented Aug 12, 2022

@mrbbot
Copy link
Contributor

mrbbot commented Aug 12, 2022

Hey! 👋 Thanks for the PR! 🙂 The problem with this fix is that if a host like 127.0.0.1 is set, we'll still log all accessible hosts, even though the server's only accessible on 127.0.0.1. Looking at the issue, I think a better fix would be to special-case 0.0.0.0 with...

- const accessibleHosts = host ? [host] : getAccessibleHosts(true);
+ const accessibleHosts = host && host !== "0.0.0.0" ? [host] : getAccessibleHosts(true);

...and leave the rest of the code as it originally was.

@Skye-31
Copy link
Contributor Author

Skye-31 commented Aug 12, 2022

Made the requested change 🙂

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you! 😃

@mrbbot mrbbot merged commit 5a48285 into cloudflare:master Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: default 0.0.0.0 wrangler dev address not routable in Windows
2 participants