Vlad/custom buffer send #1673
Open
Vlad/custom buffer send #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A BufFactory can override the generic buffer generation method with a custom method, eg. getting a buffer from a pool buffer.
Instead of copying data into internal buffers, the new methods enable queing raw buffers directly into the quiche send stream, this improves cache-locality and reduces cpu usage.
vkrasnov
force-pushed
the
vlad/custom_buffer_send
branch
from
2a7ac47
to
c0cd9d9
Compare
|
@ehaydenr FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my test setup using zero copy send with a buffer pool improves send performance by over 5%.