FFI: Expose the peer cert chain #1691
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
changed the title
bwoebi
force-pushed
the
ffi-cert-chain
branch
from
539e209
to
623b83d
Compare
bwoebi
force-pushed
the
ffi-cert-chain
branch
from
623b83d
to
eb0b707
Compare
|
@LPardue Sorry that I ping you here after 2 months now, but is there a chance that this will be reviewed and merged? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wanted to use Connection::peer_cert_chain() and realized it's not actually exposed via FFI.
The vector cannot be trivially returned by FFI, except by translating the vector to a
&[Certificate]with astruct Certificate { *mut u8; size_t; }, and then adding a free-function for this.I think directly fetching the values one by one is a superior approach for FFI purposes in terms of usability and complexity, hence this PR proposes this.