Add ability to convert errors to wire_error_code via C API #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
commented
Apr 16, 2024
| @@ -132,6 +132,10 @@ enum quiche_error { | |||
| // Returns a human readable string with the quiche version number. | |||
| const char *quiche_version(void); | |||
|
|
|||
| // Returns the wire error code for the given error as defined in RFC9000 Section 20. Error Codes. | |||
| // The given error must be a valid quiche_error. | |||
| uint64_t quiche_error_to_wire_error_code(ssize_t error); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
TBH it's not really clear why an application would want this? The 1d00ee1 change simply added public enums for the wire error codes defined in RFCs, the conversion from Error is not actually public, so this FFI change would add an API that is not actually available in Rust.
Motivation: cloudflare@1d00ee1 added the ability to retrieve the wire error code for a given error but did not add the same functionallity to the C API. Modifications: Expose functions to convert errors to wire_error_code via C Result: More complete C API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
1d00ee1 added the ability to retrieve the wire error code for a given error but did not add the same functionallity to the C API.
Modifications:
Expose functions to convert errors to wire_error_code via C
Result:
More complete C API