Add soname to libquiche.so #1769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junhochoi
force-pushed
the
fix_c_soname
branch
2 times, most recently
from
71d06fd
to
f6f3c05
Compare
|
It will also fix FreeBSD port issue too: https://lists.freebsd.org/archives/freebsd-ports/2024-April/006061.html |
junhochoi
force-pushed
the
fix_c_soname
branch
2 times, most recently
from
55843a6
to
69a5a22
Compare
ghedo
reviewed
May 9, 2024
Using cdylib-link-lines, add soname to the generated shlibs. It will add the following to libquiche.so: ``` % readelf -d target/debug/libquiche.so ... 0x000000000000000e (SONAME) Library soname: [libquiche.so.0] ``` For linux, *bsd, android, ios and macos. Fixes cloudflare#598 Fixes cloudflare#165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using cdylib-link-lines, add soname to the generated shlibs.
It will add the following to libquiche.so:
For linux, *bsd, android, ios and macos.
Fixes #598
Fixes #165