New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
(CC refactor 8) recovery: move all congestion control related fields to a new struct #1778
base: master
Are you sure you want to change the base?
Conversation
194b849
to
ed2c784
Compare
c52ef3d
to
74d6d98
Compare
// To avoid rollback | ||
r.lost_count += MIN_ROLLBACK_THRESHOLD; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is pretty obtuse to review, so I just wanted to check, is the removal here was covered somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT this was never actually necessary, because the rollback doesn't happen either way.
// To avoid rollback | ||
r.lost_count += MIN_ROLLBACK_THRESHOLD; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above regarding what this removal means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same answer :)
74d6d98
to
505df84
Compare
This creates a clearer separation between congestion and recovery.
505df84
to
fb68839
Compare
No description provided.