(CC refactor 9) recovery: move congestion into module #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junhochoi
reviewed
May 8, 2024
| on_packet_sent, | ||
| on_packets_acked, | ||
| congestion_event, | ||
| collapse_cwnd, |
There was a problem hiding this comment.
Why reset() and collape_cwnd() is removed? (I understand it's not used, but no plan to implement persistent congestion in the future?)
There was a problem hiding this comment.
We'll probably want to do it at some point... but that's been the case for years, so for now removing them simplifies the refactoring a bit. We can add them back when needed.
AFAICT these were never actually used (as in, read) anywhere.
ghedo
force-pushed
the
cc-refactor-8-cc-struct
branch
from
505df84
to
fb68839
Compare
ghedo
force-pushed
the
cc-refactor-9-cc-module
branch
from
9b27bd4
to
0152913
Compare
LPardue
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.