Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH-5403 added access custom pages as a new resource #2643

Merged
merged 6 commits into from
Aug 4, 2023

Conversation

russellkerns
Copy link
Contributor

@russellkerns russellkerns commented Aug 1, 2023

corresponding cf-go PR - cloudflare/cloudflare-go#1343

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

changelog detected ✅

@jacobbednarz jacobbednarz added the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Aug 1, 2023
@jacobbednarz
Copy link
Member

we will need to update this a little bit since the upstream PR changed the method signatures slightly.

@jacobbednarz
Copy link
Member

acceptance tests all looking good

TEST="./internal/sdkv2provider" TESTARGS='-run "^TestAccCloudflareAccess(Application|CustomPage|Organization)_" -count 1' make testacc
TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareAccess(Application|CustomPage|Organization)_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareAccessApplication_BasicZone
--- PASS: TestAccCloudflareAccessApplication_BasicZone (14.90s)
=== RUN   TestAccCloudflareAccessApplication_BasicAccount
--- PASS: TestAccCloudflareAccessApplication_BasicAccount (16.59s)
=== RUN   TestAccCloudflareAccessApplication_WithCORS
--- PASS: TestAccCloudflareAccessApplication_WithCORS (18.88s)
=== RUN   TestAccCloudflareAccessApplication_WithSaas
--- PASS: TestAccCloudflareAccessApplication_WithSaas (18.40s)
=== RUN   TestAccCloudflareAccessApplication_WithAutoRedirectToIdentity
--- PASS: TestAccCloudflareAccessApplication_WithAutoRedirectToIdentity (16.05s)
=== RUN   TestAccCloudflareAccessApplication_WithEnableBindingCookie
--- PASS: TestAccCloudflareAccessApplication_WithEnableBindingCookie (15.25s)
=== RUN   TestAccCloudflareAccessApplication_WithCustomDenyFields
--- PASS: TestAccCloudflareAccessApplication_WithCustomDenyFields (15.80s)
=== RUN   TestAccCloudflareAccessApplication_WithADefinedIdps
--- PASS: TestAccCloudflareAccessApplication_WithADefinedIdps (16.60s)
=== RUN   TestAccCloudflareAccessApplication_WithMultipleIdpsReordered
--- PASS: TestAccCloudflareAccessApplication_WithMultipleIdpsReordered (31.05s)
=== RUN   TestAccCloudflareAccessApplication_WithHttpOnlyCookieAttribute
--- PASS: TestAccCloudflareAccessApplication_WithHttpOnlyCookieAttribute (14.85s)
=== RUN   TestAccCloudflareAccessApplication_WithHTTPOnlyCookieAttributeSetToFalse
--- PASS: TestAccCloudflareAccessApplication_WithHTTPOnlyCookieAttributeSetToFalse (14.45s)
=== RUN   TestAccCloudflareAccessApplication_WithSameSiteCookieAttribute
--- PASS: TestAccCloudflareAccessApplication_WithSameSiteCookieAttribute (14.80s)
=== RUN   TestAccCloudflareAccessApplication_WithLogoURL
--- PASS: TestAccCloudflareAccessApplication_WithLogoURL (17.75s)
=== RUN   TestAccCloudflareAccessApplication_WithSkipInterstitial
--- PASS: TestAccCloudflareAccessApplication_WithSkipInterstitial (14.19s)
=== RUN   TestAccCloudflareAccessApplication_WithAppLauncherVisible
--- PASS: TestAccCloudflareAccessApplication_WithAppLauncherVisible (19.35s)
=== RUN   TestAccCloudflareAccessApplication_WithSelfHostedDomains
--- PASS: TestAccCloudflareAccessApplication_WithSelfHostedDomains (16.26s)
=== RUN   TestAccCloudflareAccessCustomPage_IdentityDenied
--- PASS: TestAccCloudflareAccessCustomPage_IdentityDenied (17.05s)
=== RUN   TestAccCloudflareAccessCustomPage_Forbidden
--- PASS: TestAccCloudflareAccessCustomPage_Forbidden (16.94s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	310.138s

@jacobbednarz jacobbednarz merged commit d8ff5ef into cloudflare:master Aug 4, 2023
8 checks passed
@github-actions github-actions bot added this to the v4.12.0 milestone Aug 4, 2023
github-actions bot pushed a commit that referenced this pull request Aug 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

This functionality has been released in v4.12.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants