Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_access_service_token: add support for Duration #2647

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

jacobbednarz
Copy link
Member

Adds coverage for Duration when managing service tokens.

Depends on cloudflare/cloudflare-go#1347

Adds coverage for `Duration` when managing service tokens.
@jacobbednarz jacobbednarz added the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Aug 2, 2023
@jacobbednarz
Copy link
Member Author

acceptance tests all passing with upstream cloudflare-go shimmed in

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareAccessServiceToken_" -count 1 -timeout 120m -parallel 1

=== RUN   TestAccCloudflareAccessServiceToken_Basic
--- PASS: TestAccCloudflareAccessServiceToken_Basic (65.17s)
=== RUN   TestAccCloudflareAccessServiceToken_Delete
--- PASS: TestAccCloudflareAccessServiceToken_Delete (33.88s)
=== RUN   TestAccCloudflareAccessServiceToken_WithDuration
--- PASS: TestAccCloudflareAccessServiceToken_WithDuration (32.93s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	132.937s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

changelog detected ✅

@jacobbednarz jacobbednarz removed the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Aug 15, 2023
@jacobbednarz jacobbednarz merged commit 377545a into master Aug 15, 2023
9 checks passed
@jacobbednarz jacobbednarz deleted the access-service-token-duration branch August 15, 2023 23:16
@github-actions github-actions bot added this to the v4.13.0 milestone Aug 15, 2023
github-actions bot pushed a commit that referenced this pull request Aug 15, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v4.13.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant