Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setting ssh encryption key in ZT settings #2826

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Add support for setting ssh encryption key in ZT settings #2826

merged 5 commits into from
Oct 16, 2023

Conversation

jroyal
Copy link
Contributor

@jroyal jroyal commented Oct 9, 2023

This relies on cloudflare/cloudflare-go#1419.

Adding support for this setting.
image

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023 •
edited

changelog detected ✅

@jacobbednarz jacobbednarz added the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Oct 11, 2023
@jacobbednarz
Copy link
Member

fixed the assertion and we're all good here now 🏆

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTeamsAccounts_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTeamsAccounts_ConfigurationBasic
--- PASS: TestAccCloudflareTeamsAccounts_ConfigurationBasic (13.43s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	14.162s

@jacobbednarz jacobbednarz merged commit 59b5023 into cloudflare:master Oct 16, 2023
9 checks passed
@github-actions github-actions bot added this to the v4.17.0 milestone Oct 16, 2023
github-actions bot pushed a commit that referenced this pull request Oct 16, 2023
Update CHANGELOG.md for #2826
d1911f8
@jroyal jroyal deleted the jroyal/audit-ssh-settings branch October 16, 2023 14:31
@github-actions
Copy link
Contributor

This functionality has been released in v4.17.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz jacobbednarz is a code owner

Assignees
No one assigned
Labels
workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library.
Projects
None yet
Milestone
v4.17.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jroyal @jacobbednarz