Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed namespaced Workers trying to delete from account rather than namespace #3238

Conversation

WalshyDev
Copy link
Member

Requires cloudflare/cloudflare-go#1737 to be released

Added CheckDestroy to acceptance test to ensure this is actually being deleted properly.
Acceptance tests:

=== RUN   TestAccCloudflareWorkersForPlatforms_NamespaceManagement
=== PAUSE TestAccCloudflareWorkersForPlatforms_NamespaceManagement
=== RUN   TestAccCloudflareWorkersForPlatforms_UploadUserWorker
=== PAUSE TestAccCloudflareWorkersForPlatforms_UploadUserWorker
=== CONT  TestAccCloudflareWorkersForPlatforms_NamespaceManagement
=== CONT  TestAccCloudflareWorkersForPlatforms_UploadUserWorker
--- PASS: TestAccCloudflareWorkersForPlatforms_NamespaceManagement (5.16s)
--- PASS: TestAccCloudflareWorkersForPlatforms_UploadUserWorker (10.16s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/workers_for_platforms	10.823s

Copy link
Contributor

This project handles dependency version bumps (including upstream changes from cloudflare-go) independently of the standard PR process using automation. This allows the dependency upgrades to land without causing merge conflicts in multiple branches and handled in a consistent way. The exception to this is security related dependency upgrades but they should be co-ordinated with the maintainer team privately.

Please remove the changes to the go.mod or go.sum files from this PR in order to proceed with review and merging.

Copy link
Contributor

github-actions bot commented Apr 10, 2024

changelog detected ✅

go.mod Outdated Show resolved Hide resolved
@WalshyDev WalshyDev force-pushed the walshy/fix-namespaced-workers-not-deleting branch from 7b71b1a to 0babc53 Compare April 11, 2024 15:17
Copy link
Contributor

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/framework/service/workers_for_platforms -v -run "^TestAccCloudflareWorkersForPlatforms_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareWorkersForPlatforms_NamespaceManagement
=== PAUSE TestAccCloudflareWorkersForPlatforms_NamespaceManagement
=== RUN   TestAccCloudflareWorkersForPlatforms_UploadUserWorker
=== PAUSE TestAccCloudflareWorkersForPlatforms_UploadUserWorker
=== CONT  TestAccCloudflareWorkersForPlatforms_NamespaceManagement
--- PASS: TestAccCloudflareWorkersForPlatforms_NamespaceManagement (10.79s)
=== CONT  TestAccCloudflareWorkersForPlatforms_UploadUserWorker
--- PASS: TestAccCloudflareWorkersForPlatforms_UploadUserWorker (12.12s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/workers_for_platforms	24.098s

@jacobbednarz jacobbednarz merged commit 919bfeb into cloudflare:master Apr 26, 2024
9 checks passed
@github-actions github-actions bot added this to the v4.31.0 milestone Apr 26, 2024
github-actions bot pushed a commit that referenced this pull request Apr 26, 2024
@WalshyDev WalshyDev deleted the walshy/fix-namespaced-workers-not-deleting branch April 26, 2024 09:53
Copy link
Contributor

github-actions bot commented May 1, 2024

This functionality has been released in v4.31.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants