-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate python import tests in bazel #2096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9ea1073
to
e06ed59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build changes make sense mod couple nits
Code LGTM, I think auto-generating tests here will be really useful in improving python test coverage. |
Could we gate the tests to only run on changes inside the pyodide folders? |
Good idea, anyone know how to do that? 🫣 Maybe Bazel's cache could be useful if someone could point me to how to configure it 😮💨 |
eb9823a
to
37289e4
Compare
7c4b6ed
to
71b4eac
Compare
71b4eac
to
7ec1d84
Compare
1898cc1
to
60cf270
Compare
@fhanau This PR is ready for review again after changes -- the tests are now configured to only run in the (linux) configuration, which was chosen because it was the fastest-running test pipeline. The idea is that the ~5 extra minutes spent on that pipeline would end up being spent on the other pipelines anyway. Will require similar CI changes upstream. |
Co-authored-by: Dominik Picheta <dominik@cloudflare.com>
63af3c9
to
91a84f4
Compare
91a84f4
to
816f051
Compare
Prerequisite: #1970
Includes: #2108
This PR adds dozens of wd-tests generated by Bazel, based off a list generated by pyodide-build-scripts from the pyodide
meta.yaml
files and added ontopyodide_bucket.bzl
.Each test simply has the tested package listed as a requirement and a
worker.py
script that just imports a bunch of stuff from that package. I expect it will take a while to get all these tests passing but we do need them to pass eventually.