Skip to content

Commit

Permalink
fix: local mode should be forced on pages dev (#2931)
Browse files Browse the repository at this point in the history
  • Loading branch information
Skye-31 committed Mar 21, 2023
1 parent 2496a42 commit 5f6c4c0
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions .changeset/cool-cobras-deliver.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"wrangler": patch
---

Fix: Pages Dev incorrectly allowing people to turn off local mode

Local mode is not currently supported in Pages Dev, and errors when people attempt to use it. Previously, wrangler hid the "toggle local mode" button when using Pages dev, but this got broken somewhere along the line.
2 changes: 1 addition & 1 deletion packages/wrangler/src/api/dev.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ export async function unstable_dev(
enablePagesAssetsServiceBinding,
liveReload,
showInteractiveDevSession,
forceLocal,
onReady: (address, port) => {
readyPort = port;
readyAddress = address;
Expand Down Expand Up @@ -232,6 +231,7 @@ export async function unstable_dev(
experimentalLocal: experimentalLocal ?? false,
experimentalLocalRemoteKv: experimentalLocalRemoteKv ?? false,
enablePagesAssetsServiceBinding,
forceLocal,
liveReload,
onReady: (address, port) => {
readyPort = port;
Expand Down

0 comments on commit 5f6c4c0

Please sign in to comment.