Skip to content

Commit

Permalink
Fix fixture types after adding entrypoints (#5499)
Browse files Browse the repository at this point in the history
* Fix fixture types after adding entrypoints

* Bump workerd@1.20240403.0 (#5498)

* Bump workerd@1.20240403.0

* Remove no-longer-necessary rpc compatibility flags
  • Loading branch information
GregBrimble committed Apr 4, 2024
1 parent cd03d1d commit 6c3be5b
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 29 deletions.
5 changes: 5 additions & 0 deletions .changeset/fluffy-dogs-confess.md
@@ -0,0 +1,5 @@
---
"miniflare": patch
---

chore: Bump workerd@1.20240403.0
1 change: 1 addition & 0 deletions fixtures/dev-env/tests/index.test.ts
Expand Up @@ -186,6 +186,7 @@ function fakeReloadComplete(
},
headers: {},
liveReload: config.dev?.liveReload,
entrypointAddresses: undefined,
};

const timeoutPromise = timers.setTimeout(delay).then(() => {
Expand Down
10 changes: 1 addition & 9 deletions fixtures/entrypoints-rpc-tests/tests/entrypoints.spec.ts
Expand Up @@ -202,7 +202,6 @@ test("should support default WorkerEntrypoint entrypoints", async ({ dev }) => {
"wrangler.toml": dedent`
name = "entry"
main = "index.ts"
compatibility_flags = ["rpc"]
[[services]]
binding = "SERVICE"
Expand Down Expand Up @@ -390,7 +389,6 @@ test("should support named WorkerEntrypoint entrypoints", async ({ dev }) => {
"wrangler.toml": dedent`
name = "entry"
main = "index.ts"
compatibility_flags = ["rpc"]
[[services]]
binding = "SERVICE"
Expand Down Expand Up @@ -446,7 +444,7 @@ test("should support named entrypoints in pages dev", async ({ dev }) => {
};
const { url } = await dev(
files,
["--compatibility-flags=rpc", "--service=SERVICE=bound#ThingEntrypoint"],
["--service=SERVICE=bound#ThingEntrypoint"],
/* pagesPublicPath */ "dist"
);

Expand All @@ -462,7 +460,6 @@ test("should support co-dependent services", async ({ dev }) => {
"wrangler.toml": dedent`
name = "a"
main = "index.ts"
compatibility_flags = ["rpc"]
[[services]]
binding = "SERVICE_B"
Expand All @@ -488,7 +485,6 @@ test("should support co-dependent services", async ({ dev }) => {
"wrangler.toml": dedent`
name = "b"
main = "index.ts"
compatibility_flags = ["rpc"]
[[services]]
binding = "SERVICE_A"
Expand Down Expand Up @@ -550,7 +546,6 @@ test("should support binding to Durable Object in another worker", async ({
"wrangler.toml": dedent`
name = "entry"
main = "index.ts"
compatibility_flags = ["rpc"]
[durable_objects]
bindings = [
Expand Down Expand Up @@ -606,7 +601,6 @@ test("should support binding to Durable Object in same worker", async ({
"wrangler.toml": dedent`
name = "entry"
main = "index.ts"
compatibility_flags = ["rpc"]
[durable_objects]
bindings = [
Expand Down Expand Up @@ -641,7 +635,6 @@ test("should support binding to Durable Object in same worker with explicit scri
"wrangler.toml": dedent`
name = "entry"
main = "index.ts"
compatibility_flags = ["rpc"]
[durable_objects]
bindings = [
Expand Down Expand Up @@ -898,7 +891,6 @@ test("should throw if performing RPC with session that hasn't started", async ({
"wrangler.toml": dedent`
name = "entry"
main = "index.ts"
compatibility_flags = ["rpc"]
[[services]]
binding = "SERVICE"
Expand Down
2 changes: 1 addition & 1 deletion packages/miniflare/package.json
Expand Up @@ -49,7 +49,7 @@
"glob-to-regexp": "^0.4.1",
"stoppable": "^1.1.0",
"undici": "^5.28.2",
"workerd": "1.20240329.0",
"workerd": "1.20240403.0",
"ws": "^8.11.0",
"youch": "^3.2.2",
"zod": "^3.20.6"
Expand Down
38 changes: 19 additions & 19 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6c3be5b

Please sign in to comment.