Remove second wrangler banner from namespace rename (#5226)

* Rename second wrangler banner from namespace rename * Add changeset * Undo formatting change * update test * update changeset --------- Co-authored-by: Peter Bacon Darwin <pbacondarwin@cloudflare.com>
cloudflare · May 2, 2024 · f63e7a5 · f63e7a5
1 parent 007ba93
commit f63e7a5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/young-chefs-change.md b/.changeset/young-chefs-change.md
@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+fix: remove second Wrangler banner from `wrangler dispatch-namespace rename`
diff --git a/packages/wrangler/src/__tests__/worker-namespace.test.ts b/packages/wrangler/src/__tests__/worker-namespace.test.ts
@@ -1,4 +1,5 @@
 import { rest } from "msw";
+import { printWranglerBanner } from "../update-check";
 import { mockAccountId, mockApiToken } from "./helpers/mock-account-id";
 import { mockConsoleMethods } from "./helpers/mock-console";
 import {
@@ -335,6 +336,7 @@ describe("dispatch-namespace", () => {
 			expect(std.out).toMatchInlineSnapshot(
 				`"Renamed dispatch namespace \\"my-namespace\\" to \\"new-namespace\\""`
 			);
+			expect((printWranglerBanner as jest.Mock).mock.calls.length).toEqual(1);
 		});
 	});
 });
diff --git a/packages/wrangler/src/dispatch-namespace.ts b/packages/wrangler/src/dispatch-namespace.ts
@@ -89,8 +89,6 @@ async function renameWorkerNamespace(
 	oldName: string,
 	newName: string
 ) {
-	void printWranglerBanner();
-
 	await fetchResult(
 		`/accounts/${accountId}/workers/dispatch/namespaces/${oldName}`,
 		{