feat: pages dev supports query params #1409
Conversation
Skye-31
requested review from
a team,
threepointone and
petebacondarwin
as code owners
🦋 Changeset detectedLatest commit: 0bce555 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2721646185/npm-package-wrangler-1409You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1409/npm-package-wrangler-1409Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2721646185/npm-package-wrangler-1409 dev path/to/script.js |
Skye-31
force-pushed
the
redirects-query-params
branch
from
6a0bc98
to
aa5de96
Compare
packages/wrangler/src/pages/dev.tsx
Outdated
| @@ -477,14 +477,14 @@ async function spawnProxyProcess({ | |||
| } | |||
|
|
|||
| function escapeRegex(str: string) { | |||
| return str.replace(/[-/\\^$*+?.()|[]{}]/g, "\\$&"); | |||
| return str.replace(/[-/\\^$*+?.()|[\]{}]/g, "\\$&"); | |||
There was a problem hiding this comment.
This may have solved a bug with parsing unusual characters
packages/wrangler/src/pages/dev.tsx
Outdated
| } | ||
|
|
||
| type Replacements = Record<string, string>; | ||
|
|
||
| function replacer(str: string, replacements: Replacements) { | ||
| for (const [replacement, value] of Object.entries(replacements)) { | ||
| str = str.replace(`:${replacement}`, value); | ||
| str = str.replaceAll(`:${replacement}`, value); |
There was a problem hiding this comment.
Docs will need to be changed to mention this (there's a PR in prod by Walshy doing the same thing)
* chore: show warnings for invalid redirect rules * fix: be strict about limit of rules
Skye-31
force-pushed
the
redirects-query-params
branch
from
d1532fd
to
73211ca
Compare
Codecov Report
@@ Coverage Diff @@
## main #1409 +/- ##
=======================================
Coverage ? 82.48%
=======================================
Files ? 85
Lines ? 5527
Branches ? 1416
=======================================
Hits ? 4559
Misses ? 968
Partials ? 0 |
|
Closing in favour of #1863 |
Closed in favour of #1863