馃殌 feat: download of Worker script --from-dash
#1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃 Changeset detectedLatest commit: f514540 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2848647603/npm-package-wrangler-1645You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1645/npm-package-wrangler-1645Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2848647603/npm-package-wrangler-1645 dev path/to/script.js |
Codecov Report
@@ Coverage Diff @@
## main #1645 +/- ##
==========================================
- Coverage 81.37% 80.96% -0.42%
==========================================
Files 90 91 +1
Lines 5955 6062 +107
Branches 1527 1555 +28
==========================================
+ Hits 4846 4908 +62
- Misses 1109 1154 +45
|
JacobMGEvans
force-pushed
the
from-dash
branch
from
1bad926
to
4aebb30
Compare
|
Video of functional testing, showing source code downloaded from dashboard of Screen.Recording.2022-08-10.at.2.01.59.PM.mov |
JacobMGEvans
force-pushed
the
from-dash
branch
2 times, most recently
from
ad7c13a
to
19be735
Compare
JacobMGEvans
changed the title
JacobMGEvans
requested review from
threepointone and
petebacondarwin
as code owners
JacobMGEvans
changed the title
--from-dash
JacobMGEvans
commented
Aug 12, 2022
JacobMGEvans
force-pushed
the
from-dash
branch
from
19be735
to
30546db
Compare
caass
approved these changes
Aug 12, 2022
Added `wrangler init --from-dash <worker-name>`, which allows initializing a wrangler project from a pre-existing worker in the dashboard. Resolves #1624 Discussion: #1623 Notes: `multiplart/form-data` parsing is [not currently supported in Undici](nodejs/undici#974), so a temporary workaround to slice off top and bottom boundaries is in place.
JacobMGEvans
force-pushed
the
from-dash
branch
from
30546db
to
f514540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for handling multipart/form-data slicing off top and bottom boundaries.
multipart/formdata not supported currently in Undici nodejs/undici#974