wrangler: add metadata to the unsafe binding

[alankemp]

This allows you to add arbitary fields to the metadata uploaded with a worker.

[unsafe.metadata]
some_key = some_value

What this PR solves / how to test:

Associated docs issues/PR:

• [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

• Tests
• Changeset

Reviewer has performed the following, where applicable:

• Checked for inclusion of relevant tests
• Checked for inclusion of a relevant changeset
• Checked for creation of associated docs updates
• Manually pulled down the changes and spot-tested

Fixes # [insert issue number].

[changeset-bot]

🦋 Changeset detected

Latest commit: 8c6ccf8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
wrangler	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4285802836/npm-package-wrangler-2665

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2665/npm-package-wrangler-2665

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4285802836/npm-package-wrangler-2665 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4285802836/npm-package-cloudflare-pages-shared-2665

Note that these links will no longer work once the GitHub Actions artifact expires.

[codecov]

Codecov Report

Merging #2665 (606e5b5) into main (6278413) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 606e5b5 differs from pull request most recent head 8c6ccf8. Consider uploading reports for the commit 8c6ccf8 to get more accurate results

@@            Coverage Diff             @@
##             main    #2665      +/-   ##
==========================================
+ Coverage   73.96%   74.04%   +0.08%     
==========================================
  Files         166      166              
  Lines       10197    10181      -16     
  Branches     2728     2711      -17     
==========================================
- Hits         7542     7539       -3     
+ Misses       2655     2642      -13     

Impacted Files	Coverage Δ
packages/wrangler/src/dev.tsx	84.25% <ø> (-0.81%)	⬇️
packages/wrangler/src/index.ts	83.92% <ø> (-0.07%)	⬇️
packages/wrangler/src/publish/publish.ts	86.66% <ø> (-0.17%)	⬇️
packages/wrangler/src/secret/index.ts	86.46% <ø> (ø)
packages/wrangler/src/worker.ts	100.00% <ø> (ø)
packages/wrangler/src/config/index.ts	96.45% <100.00%> (+0.07%)	⬆️
packages/wrangler/src/config/validation-helpers.ts	97.97% <100.00%> (ø)
packages/wrangler/src/config/validation.ts	91.07% <100.00%> (+0.19%)	⬆️
packages/wrangler/src/create-worker-upload-form.ts	90.65% <100.00%> (+0.26%)	⬆️
packages/wrangler/src/init.ts	93.78% <100.00%> (+0.01%)	⬆️
... and 16 more

[petebacondarwin]

Hmm. I am not sure about bundling the unsafe metadata and bindings into the same object here... The validateBindingsProperty is really only designed to deal with the original unsafe bindings array of objects...

[petebacondarwin]

LGTM - with a couple of nits that you can tidy up as you wish @alankemp

[alankemp]

I just tried a wrangler.toml that included unsafe.metadata but not an unsafe.binding and get an error:
- The field "unsafe" is missing the required "bindings" property.

So I need to fix that before this can be merged

[alankemp]

I just tried a wrangler.toml that included unsafe.metadata but not an unsafe.binding and get an error: - The field "unsafe" is missing the required "bindings" property.

So I need to fix that before this can be merged

This is now done.

[petebacondarwin]

I pushed a fixup commit that I think resolves the weirdness you are seeing.

See c445c55