Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Remote URL #2735

Merged
merged 10 commits into from
Apr 5, 2023
Merged

Generate Remote URL #2735

merged 10 commits into from
Apr 5, 2023

Conversation

JacobMGEvans
Copy link
Contributor

Previous URL was pointing to the old cloudflare/templates repo, updated the URL to point to templates
in the workers-sdk monorepo.

Previous URL was pointing to the old cloudflare/templates repo, updated the URL to point to templates
in the workers-sdk monorepo.
@JacobMGEvans JacobMGEvans requested a review from a team as a code owner February 15, 2023 20:45
@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2023

🦋 Changeset detected

Latest commit: 88e63a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4326499729/npm-package-wrangler-2735

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2735/npm-package-wrangler-2735

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4326499729/npm-package-wrangler-2735 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4326499729/npm-package-cloudflare-pages-shared-2735

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #2735 (88e63a4) into main (2b64176) will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2735      +/-   ##
==========================================
+ Coverage   74.05%   74.36%   +0.31%     
==========================================
  Files         166      166              
  Lines       10218    10218              
  Branches     2734     2734              
==========================================
+ Hits         7567     7599      +32     
+ Misses       2651     2619      -32     
Impacted Files Coverage Δ
packages/wrangler/src/generate/index.ts 54.05% <ø> (+12.16%) ⬆️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️
packages/wrangler/src/git-client.ts 85.41% <0.00%> (+45.83%) ⬆️

packages/wrangler/src/generate/index.ts Outdated Show resolved Hide resolved
@JacobMGEvans
Copy link
Contributor Author

JacobMGEvans commented Feb 16, 2023

I am gonna figure out a way write tests for this later.

Converting to a draft for when I have time.

@JacobMGEvans JacobMGEvans marked this pull request as draft February 16, 2023 18:22
@penalosa
Copy link
Contributor

penalosa commented Mar 3, 2023

@JacobMGEvans is there anything holding this up?

@JacobMGEvans
Copy link
Contributor Author

@JacobMGEvans is there anything holding this up?

I wanted tests for this, haven't had the time to get into Wrangler this week.

@JacobMGEvans JacobMGEvans marked this pull request as ready for review March 3, 2023 19:05
@JacobMGEvans JacobMGEvans merged commit 3f7a75c into main Apr 5, 2023
@JacobMGEvans JacobMGEvans deleted the jacobmgevans/generate-url-fix branch April 5, 2023 14:10
@github-actions github-actions bot mentioned this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants