-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add **/*.wasm?module
as a default module rule
#2783
Conversation
🦋 Changeset detectedLatest commit: 34802e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4252812557/npm-package-wrangler-2783 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2783/npm-package-wrangler-2783 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4252812557/npm-package-wrangler-2783 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4252812557/npm-package-cloudflare-pages-shared-2783 Note that these links will no longer work once the GitHub Actions artifact expires. |
As discussed offline, we feel comfortable that adding this feature will not unduly constrain Wrangler in the future:
|
Codecov Report
@@ Coverage Diff @@
## main #2783 +/- ##
==========================================
+ Coverage 73.97% 74.00% +0.02%
==========================================
Files 166 166
Lines 10163 10163
Branches 2705 2705
==========================================
+ Hits 7518 7521 +3
+ Misses 2645 2642 -3
|
I can see we have tests/fixtures for (maybe not, just asking 🙂) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 😄 (based on my very limited knowledge of this code)
What this PR solves / how to test:
Associated docs issues/PR:
.wasm?module
support cloudflare-docs#7750Author has included the following, where applicable:
Reviewer has performed the following, where applicable:
Fixes # [insert issue number].