Pages Functions Wasm cleanup #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b410c49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4354494434/npm-package-wrangler-2806You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2806/npm-package-wrangler-2806Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4354494434/npm-package-wrangler-2806 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4354494434/npm-package-cloudflare-pages-shared-2806Note that these links will no longer work once the GitHub Actions artifact expires. |
GregBrimble
force-pushed
the
pages-functions-wasm-cleanup
branch
11 times, most recently
from
133238f
to
970c80b
Compare
Codecov Report
@@ Coverage Diff @@
## main #2806 +/- ##
==========================================
- Coverage 74.05% 73.96% -0.10%
==========================================
Files 166 166
Lines 10218 10250 +32
Branches 2734 2744 +10
==========================================
+ Hits 7567 7581 +14
- Misses 2651 2669 +18
|
GregBrimble
force-pushed
the
pages-functions-wasm-cleanup
branch
from
f8b4392
to
b377669
Compare
GregBrimble
commented
Mar 1, 2023
packages/wrangler/src/pages/build.ts
Outdated
| const functionsOutfile = experimentalWorkerBundle | ||
| ? join(tmpdir(), `./functionsWorker-${Math.random()}.js`) | ||
| : outfile; | ||
| const functionsOutfile = plugin |
There was a problem hiding this comment.
We have to keep this conditional in for building Pages Plugins. I'll follow up with another PR soon which produces a outdir rather than a single file in the case of a Plugin.
packages/wrangler/src/pages/build.ts
Outdated
| const workerBundleContents = await createUploadWorkerBundleContents( | ||
| bundle as BundleResult | ||
| ); | ||
|
|
||
| mkdirSync(dirname(outfile), { recursive: true }); |
There was a problem hiding this comment.
If I specify wrangler pages functions build --outfile=some/dir/that/doesnt/exist.js it would fail which is unlike the previous pre-bundling behavior.
petebacondarwin
approved these changes
Mar 1, 2023
GregBrimble
force-pushed
the
pages-functions-wasm-cleanup
branch
from
f4911d3
to
ba7c5d4
Compare
CarmenPopoviciu
approved these changes
Mar 2, 2023
GregBrimble
force-pushed
the
pages-functions-wasm-cleanup
branch
7 times, most recently
from
2c7bcc6
to
50abac0
Compare
GregBrimble
force-pushed
the
pages-functions-wasm-cleanup
branch
from
50abac0
to
d626f62
Compare
|
Related: #2836 |
GregBrimble
force-pushed
the
pages-functions-wasm-cleanup
branch
2 times, most recently
from
3a27392
to
6f79b09
Compare
GregBrimble
force-pushed
the
pages-functions-wasm-cleanup
branch
2 times, most recently
from
8e637ff
to
9295957
Compare
|
reviewed one more time and LGTM |
… `pages publish` This is now enabled by default with intentionally no way to disable.
GregBrimble
force-pushed
the
pages-functions-wasm-cleanup
branch
from
cc6b8e7
to
b410c49
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test:
This does two big things (and one little one):
--experimental-worker-bundleoption from Pages Functions. We now just always do this. It was temporarily added for us to test the new_worker.bundleupload format.--bundleby default inpages devandpages publish. This means that you're able to use Wasm etc. in_worker.jsprojects..wasmand.binfiles as external when building a Plugin. We already do this withassets:, so there's prior art here, but this is ultimately only a stop-gap until we change the output format to an--outdirrather than an--outfilefor Plugins. We'll follow up soon-ish with that.Associated docs issues/PR:
Author has included the following, where applicable:
Reviewer has performed the following, where applicable:
Fixes # [insert issue number].