-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to @miniflare/tre@3.0.0-next.12
#2810
Conversation
🦋 Changeset detectedLatest commit: ae3f4d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4285453795/npm-package-wrangler-2810 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2810/npm-package-wrangler-2810 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4285453795/npm-package-wrangler-2810 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4285453795/npm-package-cloudflare-pages-shared-2810 Note that these links will no longer work once the GitHub Actions artifact expires. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever use of optional and nullish to create a reducer pattern.
Is the local -> miniflare2 a breaking change? Can that be notated in the changeset if it is.
I don't think so, |
d7aeb3f
to
d4e3887
Compare
Codecov Report
@@ Coverage Diff @@
## main #2810 +/- ##
==========================================
- Coverage 73.99% 73.96% -0.04%
==========================================
Files 166 166
Lines 10191 10197 +6
Branches 2722 2728 +6
==========================================
+ Hits 7541 7542 +1
- Misses 2650 2655 +5
|
d4e3887
to
ae3f4d7
Compare
What this PR solves / how to test:
This PR upgrades
@miniflare/tre
(Miniflare 3) to3.0.0-next.12
, incorporating changes from3.0.0-next.11
.Notably, this brings the following improvements to
wrangler dev --experimental-local
:workerd
/Miniflare 3 already supported Durable Objects, but Miniflare 3 didn't implement thedurableObjectsPersist
option required by Wrangler (🚀 Feature Request: Disable experimental DO persistance until Miniflare 3 supports this #2403, 🐛 BUG:wrangle dev --experimental-local
doesn't allow Durable Objects #2458)workerd
requires full URLs whenfetch
ing with service bindings (🐛 BUG: Errors on d1 when using --experimental-local #2667)SIGINT
instead ofSIGTERM
when terminatingworkerd
force closes HTTP connections, see Gracefully drain process on SIGTERM. workerd#244better-sqlite3@8
: allows installation on Node 19 (🐛 BUG: Cannot install @miniflare/tre@3.0.0-next.7 #2318)Associated docs issues/PR:
N/A
Author has included the following, where applicable:
Tests(passing existing tests)Reviewer has performed the following, where applicable:
Fixes #2318
Fixes #2403
Fixes #2458
Fixes #2667