Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring pages dev logging in line with dev proper's #2828

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

GregBrimble
Copy link
Member

What this PR solves / how to test:

Associated docs issues/PR:

Author has included the following, where applicable:

  • Tests
  • Changeset

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Fixes # [insert issue number].

@GregBrimble GregBrimble requested review from a team as code owners March 1, 2023 15:07
@changeset-bot
Copy link

changeset-bot bot commented Mar 1, 2023

🦋 Changeset detected

Latest commit: f4e206b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GregBrimble
Copy link
Member Author

cc @mrbbot for the change in unstable_dev contract (as promised)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4307712097/npm-package-wrangler-2828

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2828/npm-package-wrangler-2828

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4307712097/npm-package-wrangler-2828 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4307712097/npm-package-cloudflare-pages-shared-2828

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #2828 (f4e206b) into main (4185e96) will increase coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2828      +/-   ##
==========================================
+ Coverage   74.02%   74.08%   +0.05%     
==========================================
  Files         166      166              
  Lines       10223    10218       -5     
  Branches     2738     2734       -4     
==========================================
+ Hits         7568     7570       +2     
+ Misses       2655     2648       -7     
Impacted Files Coverage Δ
packages/wrangler/src/api/dev.ts 60.21% <ø> (ø)
packages/wrangler/src/dev.tsx 85.00% <ø> (ø)
packages/wrangler/src/dev/local.tsx 21.77% <0.00%> (-0.05%) ⬇️
packages/wrangler/src/dev/start-server.ts 65.60% <0.00%> (ø)
packages/wrangler/src/pages/dev.ts 18.77% <ø> (+0.08%) ⬆️
packages/wrangler/src/git-client.ts 43.75% <0.00%> (+4.16%) ⬆️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

packages/wrangler/src/dev/local.tsx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants