Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix API token guide link #2831

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Conversation

Skye-31
Copy link
Contributor

@Skye-31 Skye-31 commented Mar 1, 2023

What this PR solves / how to test:

The previous link for Creating an API token in a non-interactive environment 404'd, and didn't show the user any useful information. This points the link to the correct one in the docs

Associated docs issues/PR:

  • N/A

Author has included the following, where applicable:

  • Tests
  • Changeset

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@Skye-31 Skye-31 requested a review from a team as a code owner March 1, 2023 19:11
@changeset-bot
Copy link

changeset-bot bot commented Mar 1, 2023

🦋 Changeset detected

Latest commit: 1c706d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@WalshyDev WalshyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open a docs PR to redirect the old link as well please?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4317436326/npm-package-wrangler-2831

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2831/npm-package-wrangler-2831

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4317436326/npm-package-wrangler-2831 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4317436326/npm-package-cloudflare-pages-shared-2831

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #2831 (1c706d7) into main (3ad1798) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2831      +/-   ##
==========================================
+ Coverage   74.05%   74.08%   +0.02%     
==========================================
  Files         166      166              
  Lines       10218    10218              
  Branches     2734     2734              
==========================================
+ Hits         7567     7570       +3     
+ Misses       2651     2648       -3     
Impacted Files Coverage Δ
packages/wrangler/src/user/user.ts 72.31% <ø> (ø)
packages/wrangler/src/git-client.ts 43.75% <0.00%> (+4.16%) ⬆️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

@Skye-31
Copy link
Contributor Author

Skye-31 commented Mar 2, 2023

Can you open a docs PR to redirect the old link as well please?

The rule already exists at https://github.com/cloudflare/cloudflare-docs/blob/ace52a8fd4a8cceb0aff4b8664c6586e93bc9ffd/content/_redirects#L136, but functions run over that route, so none of the /api redirects are applying

@WalshyDev WalshyDev merged commit 2b64176 into cloudflare:main Mar 2, 2023
@WalshyDev WalshyDev deleted the skye/chore/fix-api-link branch March 2, 2023 20:27
@github-actions github-actions bot mentioned this pull request Mar 2, 2023
KianNH pushed a commit to KianNH/wrangler2 that referenced this pull request Mar 20, 2023
Co-authored-by: Daniel Walsh <walshydev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants